Repository navigation
fix(ci): gate release publish on the tag commit's CI and de-flake reopen test - #131
Merged
Merged
Conversation
…pen test Two defects surfaced on v0.28.3: a red CI (a flaky reopen test) did not stop the release, and the flaky test itself. Release gate: ci.yml and release-please.yml were independent push-triggered workflows with no dependency, and build-binaries only runs `cargo build` (no tests), so a red CI still published. Add a query-only `verify-ci` job that polls the SAME tag commit's CI `CI Success` job via `gh api` (no test re-run) and runs IN PARALLEL with build-binaries. The gate sits at `upload-assets` (the first public-facing step): a failed/timed-out verify-ci blocks upload-assets and, transitively, publish-release, leaving the Release a draft. build-binaries only emits throwaway artifacts (retention-days: 1), so running it in parallel is harmless and saves wall-clock. The workflow_dispatch re-attach path is a run-and-pass no-op (never skipped, so it cannot cascade-skip upload-assets). Adds `actions: read` for the gh api reads. Flaky test: reopens_cached_engine_when_db_replaced_with_new_inode asserted `assert_ne!` on the raw unix inode after delete+rebuild, but unix recycles the freed inode (both observed 1343671 under cargo llvm-cov). Drop the brittle inode assertion; the #925 contract is the behavioral outcome already asserted (reopen_count advances by exactly one, the new symbol is served, no open error), which does not depend on inode luck. The companion does_not_reopen_when_inode_is_unchanged test is unchanged.
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #131 +/- ##
==========================================
- Coverage 95.64% 95.63% -0.01%
==========================================
Files 115 115
Lines 55334 55348 +14
==========================================
+ Hits 52923 52934 +11
- Misses 2411 2414 +3 see 1 file with indirect coverage changes 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two defects surfaced on the v0.28.3 release:
ci.ymlandrelease-please.ymlare independent push-triggered workflows with no dependency, andbuild-binariesonly runscargo build(no tests). v0.28.3 published despite a failing CI.reopens_cached_engine_when_db_replaced_with_new_inode).Fix 1 — release gate (query-only, parallel)
verify-cijob polls the same tag commit's CICI Successjob viagh api— no cargo re-run (zero duplication of CI's Test job).build-binaries(which only emits throwawayretention-days: 1artifacts and never mutates the Release), so it adds ~0 wall-clock.upload-assets(the first public-facing step): a failed/timed-outverify-ciblocksupload-assets→ transitivelypublish-release, leaving the Release a draft.workflow_dispatchre-attach path = run-and-pass no-op (never skipped, so it can't cascade-skipupload-assets).actions: readpermission.Topology:
verify-ci.needs=release-please∥build-binaries.needs=release-please→upload-assets.needs=[release-please, build-binaries, verify-ci]→publish-release.needs=[…, upload-assets].Fix 2 — de-flake reopen test
assert_ne!on the raw unix inode after delete+rebuild (unix recycles the freed inode; both observed1343671undercargo llvm-cov).reopen_count+1, new symbol served, no open error) — inode-independent. Companiondoes_not_reopen_when_inode_is_unchangedunchanged.Verification
make cigreen locally.cargo llvm-cov→ zero flakes.needstopology confirmed viayaml.safe_load.Scope: test + CI-config only. No extraction/golden/
.schema/AI-crate change.